Merged
Conversation
potiuk
added
the
canary
potiuk
force-pushed
the
faster-doc-build-in-canary-builds
branch
2 times, most recently
from
0ef031d to
3c99706
Compare
hussein-awala
approved these changes
Aug 2, 2024
shahar1
reviewed
Aug 2, 2024
Member
Author
|
Right. :) |
shahar1
approved these changes
Aug 2, 2024
Contributor
|
Hmm, looks like it fails here: |
Self-hosted runners on ASF are SLOW to build docs (much slower than regular public runners) but they have more disk space which is needed to publish documentation. This PR splits docs building process to two steps: * First step that builds docs and uploads them as artifacts run on public runners * Publish step that downloads the artifact and publishes them to S3 (this one needs more space and runs on ASF self-hosted runners) This has the nice side effect that docs built in PR are available as artifacts in PRs and main build.
potiuk
force-pushed
the
faster-doc-build-in-canary-builds
branch
from
babfb89 to
99fba65
Compare
Member
Author
Yep. Just corrected it. |
Member
Author
|
It works now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-hosted runners on ASF are SLOW to build docs (much slower than
regular public runners) but they have more disk space which is needed
to publish documentation. This PR splits docs building process to two
steps:
First step that builds docs and uploads them as artifacts run on
public runners
Publish step that downloads the artifact and publishes them to
S3 (this one needs more space and runs on ASF self-hosted runners)
This has the nice side effect that docs built in PR are available
as artifacts in PRs and main build.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.