Disable internal RPC API tests in isolation mode#41236
Merged
potiuk merged 3 commits intoapache:mainfrom Aug 3, 2024
Merged
Conversation
potiuk
approved these changes
Aug 3, 2024
potiuk
approved these changes
Aug 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #41067
Sounds a bit strange but in the RPC API tests the pytest spawns its own internal flask server which conflicts with the separate started by pytest.
As long as we do not have only/exclusive internal API tests, we must disable these in isolation mode.
I tried to make them working but also if the internal API server is started in pytest, a DB access is needed which heavily conflicts with the traceback session mode. Main conflict is within
minimal_app_for_internal_api()mock