Handle executor events in dag.test()#41625
Merged
vincbeck merged 3 commits intoapache:mainfrom Aug 22, 2024
Merged
Conversation
o-nikolas
reviewed
Aug 20, 2024
Contributor
o-nikolas
left a comment
There was a problem hiding this comment.
Any way to add some tests so that this doesn't regress again? Does the dag.test code itself even have unit tests?
Contributor
Author
It does but we are not testing |
o-nikolas
approved these changes
Aug 21, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the task did not reach the task runner environment and fails, no update is made in the DB. The executor is sending "events" that are handled by the scheduler. In
dag.test(), there is no scheduler, therefore we need to handle them there as well.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.