Add google-cloud-spanner[testing] extra to devel-dependencies#42074
Closed
rbarrette wants to merge 1 commit intoapache:mainfrom
Closed
Add google-cloud-spanner[testing] extra to devel-dependencies#42074rbarrette wants to merge 1 commit intoapache:mainfrom
rbarrette wants to merge 1 commit intoapache:mainfrom
Conversation
boring-cyborg
Bot
added
area:providers
provider:google
rbarrette
force-pushed
the
update-devel-google-testing
branch
from
cdcde43 to
6c7ce81
Compare
Author
|
Noticed the 3.49.0 python-spanner release has been yanked, updated dependencies accordingly. |
potiuk
reviewed
Sep 7, 2024
| dependencies: | ||
| - apache-airflow-providers-amazon>=2.6.0 | ||
|
|
||
| devel-dependencies: |
Member
There was a problem hiding this comment.
In 3.49.1 there is no 'testing' extra any more - because google team decided to make it back a "requirement" - so we cannot really get this one :(
potiuk
requested changes
Sep 7, 2024
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
We don't need to do anything here:
- exclusion is fine, regardless of the release being yanked
- for now at least 3.49.1 does not have "testing" extra any more - the interceptor has been moved back into "Required" section.
Author
You're right. I should have verified the release matched up with the proposed changes in the googleapis/python-spanner#1193. Valuable lesson here for me. Thanks for the patience @potiuk. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #42011
See: googleapis/python-spanner#1193
@potiuk, I know you said you guys would run with this one, really wanted to contribute tho!
I left your prior changes from #42011 as google did not yank the 3.49.0 release of python-spanner.Adds google-cloud-spanner[testing] to devel-dependencies in google the provider yaml
related: #42011
See: googleapis/python-spanner#1193
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.