Skip to content

reformat summary commands#42171

Merged
uranusjr merged 4 commits intoapache:mainfrom
leoguzman:cleanup_docs
Sep 11, 2024
Merged

reformat summary commands#42171
uranusjr merged 4 commits intoapache:mainfrom
leoguzman:cleanup_docs

Conversation

@leoguzman
Copy link
Contributor


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 11, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@leoguzman
Copy link
Contributor Author

@RNHTTR @jedcunningham

Copy link
Contributor

@RNHTTR RNHTTR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RST doesn't render code blocks the same way as markdown. You can go to the "Files changed" tab then click the three dots then "View File" to see a preview of the file.

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Copy link
Contributor

@RNHTTR RNHTTR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RST doesn't render code blocks the same way as markdown. You can go to the "Files changed" tab then click the three dots then "View File" to see a preview of the file.

@RNHTTR RNHTTR dismissed jedcunningham’s stale review September 11, 2024 19:58

this has been addressed

@uranusjr uranusjr merged commit 0fc1582 into apache:main Sep 11, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 11, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants