[AIRFLOW-3066] Adding support for AWS Batch parameters#4231
Closed
hugoprudente wants to merge 0 commit intoapache:masterfrom
Closed
[AIRFLOW-3066] Adding support for AWS Batch parameters#4231hugoprudente wants to merge 0 commit intoapache:masterfrom
hugoprudente wants to merge 0 commit intoapache:masterfrom
Conversation
Fokko
requested changes
Nov 25, 2018
Contributor
There was a problem hiding this comment.
Can we use the >> notation here?
Contributor
There was a problem hiding this comment.
Do we need the if construction here? Can't we just pass None parameters? Or do parameters =self.parameters or {}
Author
There was a problem hiding this comment.
The API does not accept None parameters or {}, both triggers KeyError exception.
esthernamrm
reviewed
Nov 28, 2018
There was a problem hiding this comment.
Really happy this is being added! Would it make sense to name the keyword arg job_parameters to better differentiate it from the params keyword arg?
|
Will this be merge into master any time soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation
Code Quality
flake8