Clarify logic in callback func in is authorized callback#42475
Merged
dstandish merged 7 commits intoapache:mainfrom Sep 26, 2024
Merged
Conversation
I think this makes it a little clearer what the logic is doing. Ultimately I would change this to return False instead of raise but I'm doing raise, but I want to see what happens in the tests. Does this combination ever happen?
This reverts commit 3a6b660.
dstandish
commented
Sep 25, 2024
dstandish
commented
Sep 25, 2024
dstandish
commented
Sep 25, 2024
dstandish
commented
Sep 25, 2024
Contributor
Author
|
@vincbeck if you have a min to look tomorrow |
vincbeck
approved these changes
Sep 26, 2024
dstandish
deleted the
clarify-logic-in-callback-func-in-is_authorized_callback
branch
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
I think this makes it a little clearer what the logic is doing.
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
I think this makes it a little clearer what the logic is doing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to make clearer what this is doing by splitting things out a bit.