Skip to content

Remove AIRFLOW_V_2_7_PLUS constant#42627

Merged
vincbeck merged 1 commit intoapache:mainfrom
aws-mwaa:vincbeck/airflow_2_7
Oct 1, 2024
Merged

Remove AIRFLOW_V_2_7_PLUS constant#42627
vincbeck merged 1 commit intoapache:mainfrom
aws-mwaa:vincbeck/airflow_2_7

Conversation

@vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Oct 1, 2024

Min airflow version in providers is 2.8, thus this constant is no longer used.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vincbeck vincbeck merged commit 6e3118a into apache:main Oct 1, 2024
@vincbeck vincbeck deleted the vincbeck/airflow_2_7 branch October 1, 2024 19:37

@pytest.mark.skipif(not AIRFLOW_V_2_7_PLUS, reason="The tests should be skipped for Airflow < 2.7")
@pytest.mark.skipif(not AIRFLOW_V_2_8_PLUS, reason="The tests should be skipped for Airflow < 2.8")
def some_test_that_only_works_for_airflow_2_7_plus():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--- def some_test_that_only_works_for_airflow_2_7_plus():
+++ def some_test_that_only_works_for_airflow_2_8_plus():

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf, I already merged it. I'll create a PR for it

joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants