-
Notifications
You must be signed in to change notification settings - Fork 16.2k
ci(basic-tests): add missing standard provider #42654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(basic-tests): add missing standard provider #42654
Conversation
|
Ah ryt I have added this into bash operator there were tests failing in the pr due to standard procedure not installing, the pr is in review. |
0af9887 to
329c8f4
Compare
|
#42506 this has changes to provider manager and bash operator changes, in my opinion it breaks k8s tests also as there is import being used in celery executor utils . Because standard provider not getting installing in the container. It would be better to revert the changes ? |
|
for short term solution, we probably could go with this one. for long term, we will need to add it as fab dep and wait for its release |
|
Agree. API client works with this change , but my hunch is on k8s test might fail. |
|
And docker tests as well... As a workaround I have added skipif here #42252. But don't like skipping these tests not good. It would be better to release the standard provider basic version and installing it default provider lists. |
|
Created revert pr #42659 |
|
Ok, then let's use the revert commit and close this one. Thanks @gopidesupavan ! |
|
See the discussion in https://lists.apache.org/thread/1gshy5cjmp9wz5v8dozyh64jj3dyn5s4 - I think we should start releasing ".dev*" standard provider to PyPI manually to overcome some of the chicken-egg problems experienced here and avoiding the neeed for "skip-if" |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.