Add on_kill equivalent to Databricks SQL Hook to cancel timed out queries#42668
Merged
uranusjr merged 212 commits intoapache:mainfrom Nov 13, 2024
Merged
Conversation
457a345 to
5a01d2a
Compare
added 9 commits
October 2, 2024 11:36
This reverts commit 13287fcc63cfe2f3df548c287bd6386007520167.
5a01d2a to
75f8c05
Compare
Lee-W
reviewed
Oct 4, 2024
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Contributor
Author
|
@Lee-W - Could you help me understand why the new exceptions are not being found in
The exceptions are present in the file and are able to be successfully imported locally when I run Also, the DB tests seem to be failing because of tests unrelated to my changes, or I'm missing how they are connected. |
Lee-W
approved these changes
Oct 28, 2024
Member
|
LGTM |
Contributor
Author
|
hey @uranusjr - Can you please review as your requested changes should be addressed now? 🙏 |
Contributor
Author
|
Wanted to nudge on this again. @uranusjr - Is there any timeline for when you could re-review? |
uranusjr
approved these changes
Nov 13, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Databricks Provider did not implement a mechanism to cancel SQL queries submitted by DatabricksSqlHook. This led to data quality issues, where Airflow would report a cancellation due to timeout; however, the corresponding SQL query would continue to run on Databricks.
This PR uses threading to cancel SQL queries submitted by DatabricksSqlHook.run() once the timeout is exceeded.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.