Skip to content

fix PyDocStyle checks#42841

Merged
ferruzzi merged 6 commits intoapache:mainfrom
dannyl1u:pydocstylechecks
Oct 9, 2024
Merged

fix PyDocStyle checks#42841
ferruzzi merged 6 commits intoapache:mainfrom
dannyl1u:pydocstylechecks

Conversation

@dannyl1u
Copy link
Contributor

@dannyl1u dannyl1u commented Oct 8, 2024

related: #40567
PT004 | Fixture does not return anything, add leading underscore
Reduces PT004 errors from 345 to 318.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Oct 8, 2024
@dannyl1u dannyl1u marked this pull request as draft October 8, 2024 21:07
@dannyl1u dannyl1u marked this pull request as ready for review October 9, 2024 17:49
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

views.py will be removed in 3.0 do actually this PR improves testing in almost dead code... but anyway still improves :-D

@ferruzzi ferruzzi merged commit 51f6e2f into apache:main Oct 9, 2024
@dannyl1u dannyl1u deleted the pydocstylechecks branch October 9, 2024 18:42
kunaljubce pushed a commit to kunaljubce/airflow that referenced this pull request Oct 13, 2024
pavansharma36 pushed a commit to pavansharma36/airflow that referenced this pull request Oct 14, 2024
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants