Conversation
|
Why? Can you explain? What is source documentation? Can you please add a unit test to cover this change? |
|
Hi @potiuk , it seems like typo in my repair run PR, I have tested on our dev, for deferrable, it is working as expected, but in normal, it is failing, you can find error in screenshot below, thanks
|
Which PR? And I think in either case - if this is "correct fix" - generally speaking we do not accept PRs like that which have no unit test changes - because it means that the "bad" functionality did not have a good unit test. If it did, the test would fail after your change and you would have to correct the test as well) - so adding a unit test here is pretty much mandatory. |
|
Hi @potiuk , sure will add a unit test case for the same, in earlier PR, I think unit test case was there, but that covered only the deferrable one, From a functionality point of view, it is the same, no worries, I will add a test case for this as well |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |

Fix repair function calling, only repair_dict need to get passed
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.