Skip to content

Fix repair function call#42945

Closed
gaurav7261 wants to merge 1 commit intoapache:mainfrom
gaurav7261:patch-1
Closed

Fix repair function call#42945
gaurav7261 wants to merge 1 commit intoapache:mainfrom
gaurav7261:patch-1

Conversation

@gaurav7261
Copy link
Contributor

Fix repair function calling, only repair_dict need to get passed


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Oct 14, 2024

Why? Can you explain? What is source documentation?

Can you please add a unit test to cover this change?

@gaurav7261
Copy link
Contributor Author

gaurav7261 commented Oct 14, 2024

Hi @potiuk , it seems like typo in my repair run PR, I have tested on our dev, for deferrable, it is working as expected, but in normal, it is failing, you can find error in screenshot below, thanks

Screenshot 2024-10-14 at 12 42 51 PM

@potiuk
Copy link
Member

potiuk commented Oct 14, 2024

Hi @potiuk , it seems like typo in my repair run PR, I have tested on our dev, for deferrable, it is working as expected, but in normal, it is failing, you can find error in screenshot below, thanks

Which PR?

And I think in either case - if this is "correct fix" - generally speaking we do not accept PRs like that which have no unit test changes - because it means that the "bad" functionality did not have a good unit test. If it did, the test would fail after your change and you would have to correct the test as well) - so adding a unit test here is pretty much mandatory.

@gaurav7261
Copy link
Contributor Author

gaurav7261 commented Oct 15, 2024

Hi @potiuk , sure will add a unit test case for the same, in earlier PR, I think unit test case was there, but that covered only the deferrable one, From a functionality point of view, it is the same, no worries, I will add a test case for this as well

@github-actions
Copy link

github-actions bot commented Dec 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 1, 2024
@github-actions github-actions bot closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:databricks stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants