Skip to content

Add timezone selection to new UI#43132

Merged
bbovenzi merged 1 commit intoapache:mainfrom
astronomer:add-timezone-selector
Oct 17, 2024
Merged

Add timezone selection to new UI#43132
bbovenzi merged 1 commit intoapache:mainfrom
astronomer:add-timezone-selector

Conversation

@bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Oct 17, 2024

Let users specify their preferred timezone.

Add a Timezone context which reads and write to local storage, and passes the selected timezone down to all <Time /> components. Also, always show UTC and the guessed TZ at the top of the search list.

Closes #42817
Related #42821

Screenshot 2024-10-17 at 4 41 44 PM Screenshot 2024-10-17 at 4 41 48 PM Screenshot 2024-10-17 at 4 41 57 PM

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 17, 2024
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Tested and all look good!

The only think that I favor from the previous UI: Less clicks needed to switch between time zones :-)

@bbovenzi
Copy link
Contributor Author

bbovenzi commented Oct 17, 2024

Cool!

Tested and all look good!

The only think that I favor from the previous UI: Less clicks needed to switch between time zones :-)

I noticed that too with moving light/dark mode inside user settings. So I might try to redesign that

@jscheffl
Copy link
Contributor

Cool!
Tested and all look good!
The only think that I favor from the previous UI: Less clicks needed to switch between time zones :-)

I noticed that too with moving light/dark mode inside user settings. So I might try to redesign that

But no force to have this in this PR... can also be a follow-up optimization. Critical functions in sceleton are more important (I think...)

@bbovenzi bbovenzi merged commit 15f09c7 into apache:main Oct 17, 2024
@bbovenzi bbovenzi deleted the add-timezone-selector branch October 17, 2024 22:00
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a clock widget with timezone support in new UI

2 participants