Update cloudant versions to be py-version aware so uv lock can work.#43217
Merged
Update cloudant versions to be py-version aware so uv lock can work.#43217
uv lock can work.#43217Conversation
When we are building th provider dists we exclude 3.9 support, but when uv is looking at requrements it doesn't/can't respect this field, so we have to make the depenedency aware of python version too. This makes `uv lock` and `uv sync` both worth, which should be the required step for switching uv to the local venv workflow
Member
Author
|
Relates to #43200 |
eladkal
approved these changes
Oct 21, 2024
hussein-awala
approved these changes
Oct 21, 2024
sunank200
approved these changes
Oct 21, 2024
phanikumv
approved these changes
Oct 21, 2024
Member
Author
|
Just failing with the known WTForms issue. Merging |
Member
Author
|
Can someone test if this lets If not then add |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 21, 2024
…can work. (apache#43217)" This reverts commit 892b2f1.
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
apache#43217) When we are building th provider dists we exclude 3.9 support, but when uv is looking at requrements it doesn't/can't respect this field, so we have to make the depenedency aware of python version too. This makes `uv lock` and `uv sync` both worth, which should be the required step for switching uv to the local venv workflow
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
apache#43217) When we are building th provider dists we exclude 3.9 support, but when uv is looking at requrements it doesn't/can't respect this field, so we have to make the depenedency aware of python version too. This makes `uv lock` and `uv sync` both worth, which should be the required step for switching uv to the local venv workflow
Contributor
"uv sync" worked for me, but it creates a "uv.lock" file which isn't in version control and isn't in .gitignore. Possibly we want to add it to github based off this: https://docs.astral.sh/uv/guides/projects/#uvlock |
83 tasks
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
apache#43217) When we are building th provider dists we exclude 3.9 support, but when uv is looking at requrements it doesn't/can't respect this field, so we have to make the depenedency aware of python version too. This makes `uv lock` and `uv sync` both worth, which should be the required step for switching uv to the local venv workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have this:
However when uv is looking at requirements it doesn't/can't respect this field, so we have to make
the dependency aware of python version too.
This makes
uv lockanduv syncboth worth, which should be the requiredstep for switching uv to the local venv workflow.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.