Add reprocessing behavior for backfill#43382
Merged
dstandish merged 2 commits intoapache:mainfrom Oct 28, 2024
Merged
Conversation
boring-cyborg
bot
added
area:db-migrations
dstandish
force-pushed
the
aip-78-clearing-behavior-just-add-dag-runs
branch
2 times, most recently
from
16227d5 to
c6b7a26
Compare
dstandish
requested review from
Lee-W,
ephraimbuddy,
jedcunningham,
kaxil and
uranusjr
dstandish
force-pushed
the
aip-78-clearing-behavior-just-add-dag-runs
branch
from
aff73d0 to
991e68c
Compare
Contributor
Author
|
Alright this should be good to go. Think I have it to pretty stable place / sensible behavior. |
dstandish
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
jscheffl
approved these changes
Oct 26, 2024
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
I don't know if I asked before... no API changes on FastAPI? Still building this function on the legacy API which should go away?
dstandish
added
the
legacy api
Contributor
Author
the project began before the new API was there and i just wanted to focus on finishing the AIP. we will need to migrate it. also, from looking at some of the migrated routes i'm not sure if the security part of things has been figured out yet either. |
dstandish
force-pushed
the
aip-78-clearing-behavior-just-add-dag-runs
branch
from
414534a to
4364927
Compare
User can decide whether we should create a new run or not when a run already exists. For now, we just look at the latest instance of the by start date. If it's in flight we do not create. If it's done, we may or may not create depending on state and desired reprocessing behavior.
dstandish
force-pushed
the
aip-78-clearing-behavior-just-add-dag-runs
branch
from
01b7b6a to
c70441c
Compare
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
User can decide whether we should create a new run or not when a run already exists. For now, we just look at the latest instance of the by start date. If it's in flight we do not create. If it's done, we may or may not create depending on state and desired reprocessing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User can decide whether we should create a new run or not when a run already exists. For now, we just look at the latest instance of the by start date. If it's in flight we do not create. If it's done, we may or may not create depending on state and desired reprocessing behavior.
There are three options for reprocessing behavior:
If the latest run is still running or is queued, we do not create another run, no matter the chosen reprocessing behavior.