Correcting the wildcard character for _SearchParam#43780
Merged
phanikumv merged 1 commit intoapache:mainfrom Nov 7, 2024
Merged
Correcting the wildcard character for _SearchParam#43780phanikumv merged 1 commit intoapache:mainfrom
phanikumv merged 1 commit intoapache:mainfrom
Conversation
amoghrajesh
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
pierrejeambrun
approved these changes
Nov 7, 2024
Member
|
Thanks |
Lee-W
approved these changes
Nov 7, 2024
ephraimbuddy
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fastAPI endpoints using Search Param such as DAG filtering using
dag_id_patternordag_display_name_patterndon't return the correct result because of a wrong wildcard entry in the ORM filtering.Example:
After the fix:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.