Generate openapi.json for the Execution API sub-app#43796
Merged
kaxil merged 1 commit intoapache:mainfrom Nov 7, 2024
Merged
Conversation
`include_in_schema=False` this flag meant none of the path operations were included in `/execution/openapi.json`. This was initially done to ensure this paths aren't included in the top-level client but since it is a separate App, it doesn't include the path operations on `/openapi.json` (used by UI and generated OpenAPI client) but only for App on `/execution` .
ashb
changed the title
ashb
approved these changes
Nov 7, 2024
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Tested that the operations don't shoe up in /openapi.json or in the rendered /docs, but only in /execution/openapi.json with this change.
Member
|
Nice! |
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
`include_in_schema=False` this flag meant none of the path operations were included in `/execution/openapi.json`. This was initially done to ensure this paths aren't included in the top-level client but since it is a separate App, it doesn't include the path operations on `/openapi.json` (used by UI and generated OpenAPI client) but only for App on `/execution` .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include_in_schema=Falsethis flag meant none of the path operations were included in/execution/openapi.json. This was initially done to ensure this paths aren't included in the top-level client but since it is a separate App, it doesn't include the path operations on/openapi.json(used by UI and generated OpenAPI client) but only for App on/execution.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.