BUG Update initialise_virtualenv.py to use uv sync#44096
Merged
Conversation
Contributor
Author
|
even with this changes there is still a bug: Observation: |
Member
|
If we use Might be worth to describe this behaviour and where the venv is created in the docs which refer to this script. |
Contributor
Author
|
Should I add |
Member
|
No - it's already added by "hatch_build.py" via sqlite dependency. What you needed to do (see the fixup I added) - is to run the airflow commands via "uv run" command. |
potiuk
approved these changes
Nov 17, 2024
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
* Update initialse_virtualenv.py to use uv sync * fixup! Update initialse_virtualenv.py to use uv sync --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #44078
uvis the recommended tool for installingairflowand other dependecies. I updated the./scripts/tool/initialise_virtualenv.pyfile to useuv syncinstead ofpip unstall