Fix Pydantic model in Airflow 2.10 back-compat tests for Edge#44099
Merged
potiuk merged 2 commits intoNov 16, 2024
Conversation
potiuk
approved these changes
Nov 16, 2024
Member
|
Good hint with whitespace |
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken canary test. See:
https://github.com/apache/airflow/actions/runs/11872681950/job/33086780319
After fixing the one problem there was also a error appearing in collection of non-db tests for this PR. Therefore needed to adjust pytests which are known not to be working in Airflow 3. DIFF looks large but it is actually just 200 lines indented. Difference is just an IF and re-formatting. Hiding white-space changes help as
