Skip to content

[AIRFLOW-4469] Support for new version of python jenkins#4414

Closed
sarmadali20 wants to merge 1 commit intoapache:masterfrom
sarmadali20:patch-2
Closed

[AIRFLOW-4469] Support for new version of python jenkins#4414
sarmadali20 wants to merge 1 commit intoapache:masterfrom
sarmadali20:patch-2

Conversation

@sarmadali20
Copy link
Contributor

@sarmadali20 sarmadali20 commented Dec 31, 2018

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

@Fokko
Copy link
Contributor

Fokko commented Jan 2, 2019

@sarmadali20 Please file a Jira issue.

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to update the minimum required version of python-jenkins in setup.py

@ashb ashb changed the title Support for new version of python jenkins [AIRFLOW-4469] Support for new version of python jenkins Jun 19, 2019
@stale
Copy link

stale bot commented Sep 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 3, 2019
@stale stale bot closed this Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants