Make filters param optional and fix typing#44226
Merged
dstandish merged 1 commit intoapache:mainfrom Nov 21, 2024
Merged
Conversation
dstandish
requested review from
XD-DENG,
ashb,
ephraimbuddy and
pierrejeambrun
as code owners
boring-cyborg
bot
added
the
area:Scheduler
dstandish
force-pushed
the
make-filters-optional
branch
from
2b3838f to
697edf0
Compare
Lee-W
approved these changes
Nov 21, 2024
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
Overall looks good besides changing the var name in list comprehension to x, but I think it's more like a personal taste 🤔
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice, just one question
ashb
reviewed
Nov 21, 2024
amoghrajesh
reviewed
Nov 21, 2024
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
No major comments, just found the newer version with for x in event_logs or for x in assets etc less readable.
dstandish
force-pushed
the
make-filters-optional
branch
from
68c3458 to
91190fd
Compare
Given that sometimes we don't want to apply any filters, it makes sense to make the param optional. I also fix the typing on `paginated_select`.
dstandish
force-pushed
the
make-filters-optional
branch
from
91190fd to
a52a6d4
Compare
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Given that sometimes we don't want to apply any filters, it makes sense to make the param optional. I also fix the typing on `paginated_select`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that sometimes we don't want to apply any filters, it makes sense to make the param optional. I also fix the typing on
paginated_select.