Skip to content

Comments

Bump Ruff to 0.8.0#44287

Merged
jedcunningham merged 1 commit intoapache:mainfrom
AlexWaygood:update-ruff
Nov 22, 2024
Merged

Bump Ruff to 0.8.0#44287
jedcunningham merged 1 commit intoapache:mainfrom
AlexWaygood:update-ruff

Conversation

@AlexWaygood
Copy link
Contributor

@AlexWaygood AlexWaygood commented Nov 22, 2024

pypi.org/project/ruff/0.8.0

Hi! I just released Ruff 0.8.0. This release removes a few rules that had been deprecated for a few releases, so Ruff 0.8.0 would have started emitting warnings when linting trio due to the fact that you have some of these now-removed rules explicitly ignored in your Ruff config.

This PR gets rid of the removed rules from your Ruff config. There's also some additional changes made here; let me know if any of them are undesirable, and I can revert them:

  • The flake8-type-checking rules have been recoded from TCH to TC; I updated noqa comments and configuration settings related to these so that they use the new error codes
  • dev/breeze/src/airflow_breeze/utils/console.py was changed slightly due to autofix for UP015, which has been improved in the latest release

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 22, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@jedcunningham jedcunningham merged commit ab38d01 into apache:main Nov 22, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 22, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@jedcunningham
Copy link
Member

jedcunningham commented Nov 22, 2024

Thanks @AlexWaygood! Appreciate you coming over and doing the update for us. Congrats on your first Airflow commit 🎉

@AlexWaygood AlexWaygood deleted the update-ruff branch November 22, 2024 21:33
@AlexWaygood
Copy link
Contributor Author

No problem, glad I could help!

@potiuk
Copy link
Member

potiuk commented Nov 23, 2024

REALLLY NICE @AlexWaygood ...

BTW. Question - out of curiosity - was it some tool or Ai used to generate those 8 PRs you opened to all the repositories ? Or was it purely manually done?

I am not complaining of course, quite the opposite, but trying to figure out various automation patterns in tooling and devex. This is actually a cool idea I've been exploring with Alpha Omega Fund I work - to be able to build some kind of (automated) network of OSS projects that depend on other projects and run some checks, verifications, and eventually like you did, automated PRs to fix problems found in other projects - and this seems like a cool idea if we could help various libraries to help their users to be upgraded quicker and more automatically. I'd be courious to talk about it if you'd be interested - shoot me a message at my email from GitHub profile if you'd be interested.

got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants