Test DagFileProcessorManager directly, not via the JobRunner#44642
Merged
Conversation
90% of these tests created a DagProcessorJobRunner with the Manager inside it, then did absolutely nothing with the JobRunner object. This makes the tests more directly use what they are testing. (DagProcessorJobRunner itself is as simple as can be -- it calls `start()` -> `terminate()` -> `end()` so we don't loose much of anything by not testing it explicitly)
ashb
commented
Dec 4, 2024
phanikumv
approved these changes
Dec 4, 2024
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…44642) 90% of these tests created a DagProcessorJobRunner with the Manager inside it, then did absolutely nothing with the JobRunner object. This makes the tests more directly use what they are testing. (DagProcessorJobRunner itself is as simple as can be -- it calls `start()` -> `terminate()` -> `end()` so we don't loose much of anything by not testing it explicitly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
90% of these tests created a DagProcessorJobRunner with the Manager inside it,
then did absolutely nothing with the JobRunner object. This makes the tests
more directly use what they are testing. (The rest of the time already created
the Manager directly)
(DagProcessorJobRunner itself is as simple as can be -- it calls
start()->terminate()->end()so we don't loose much of anything by not testing itexplicitly)