AIP-72: Scaffold task instance RTIF API calls during task startup#44725
Merged
amoghrajesh merged 10 commits intoapache:mainfrom Dec 10, 2024
Merged
AIP-72: Scaffold task instance RTIF API calls during task startup#44725amoghrajesh merged 10 commits intoapache:mainfrom
amoghrajesh merged 10 commits intoapache:mainfrom
Conversation
amoghrajesh
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
amoghrajesh
requested review from
ashb and
kaxil
and removed request for
ephraimbuddy and
pierrejeambrun
amoghrajesh
commented
Dec 6, 2024
amoghrajesh
changed the title
ashb
reviewed
Dec 6, 2024
ashb
reviewed
Dec 6, 2024
ashb
reviewed
Dec 6, 2024
ashb
approved these changes
Dec 10, 2024
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
One minor point about the name, otherwise LGTM!
Contributor
Author
|
Thanks for the review, merging this one. |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependent on #44692 and only commit: 91ec038 onwards is relevant.
This PR adds an example of how we should be calling the
set_rtifendpoint as introduced in #44692 from the task runner.The idea is to implement a portion where we call this API using maybe dummy values from task sdk - startup(). Later when we have mechanism for "rendering", we can replace the params
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.