[Edge] Fix edge worker api support none default base api url#44732
Merged
jscheffl merged 4 commits intoapache:mainfrom Dec 9, 2024
Merged
Conversation
boring-cyborg
bot
added
area:providers
provider:edge
jscheffl
reviewed
Dec 6, 2024
jscheffl
requested changes
Dec 6, 2024
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Change is good in general but breaks Airflow 2.10 RPCAPI.
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
jscheffl
approved these changes
Dec 9, 2024
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Thanks! After the fix it now works licke a charm!
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…44732) * Fix method compare of api call * Removed first slash from prue_method name * Update providers/src/airflow/providers/edge/CHANGELOG.rst * Update providers/src/airflow/providers/edge/worker_api/auth.py Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> --------- Co-authored-by: Marco Küttelwesch <marco.kuettelwesch@de.bosch.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If Airflow deployment runs on none default base url the Edge worker api auth fails. The Edge worker api auth compares the method names which include the url path. But auth does not know on which sub url it is running. Auth detects a mismatch and blocks the request.
Details about changes