Correctly ensure that we give subprocesses time to exit after signalling it#44766
Merged
Correctly ensure that we give subprocesses time to exit after signalling it#44766
Conversation
…ing it We had a bug hidden in our tests by our use of mocks -- if the subprocess returned any output, then `self.selector.select()` would return straight away, not waiting for the maximum timeout, which would result in the "escalation" signal being sent after one outout, not after the given interval.
eladkal
approved these changes
Dec 7, 2024
shahar1
approved these changes
Dec 7, 2024
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…ing it (apache#44766) We had a bug hidden in our tests by our use of mocks -- if the subprocess returned any output, then `self.selector.select()` would return straight away, not waiting for the maximum timeout, which would result in the "escalation" signal being sent after one output, not after the given interval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a bug hidden in our tests by our use of mocks -- if the subprocess
returned any output, then
self.selector.select()would return straight away,not waiting for the maximum timeout, which would result in the "escalation"
signal being sent after one outout, not after the given interval.
Discovered while looking into #44760 (comment)