Refactor stat helper methods on DagFileProcessorManager#44818
Merged
Conversation
This is some cleanup/preporatory work in order to swap the Dag processor over to use the TaskSDK, and this small change is done to make the future work easier. The main bulk of this change is to remote the `get_*` helper methods and make `_file_stats` a defaultdict instead, and then also swap the DagFileStat class from a NamedTuple (which can't have defaults) to an attrs-defined class which does. To make some of the places of use nicer/still one line, the type of last_duration was changed form a timedelta to a float, as this was what the `get_last_runtime` method did, and we don't need any of the capabilities of a timedelta object elsewhere.
boring-cyborg
bot
added
the
area:Scheduler
kaxil
reviewed
Dec 10, 2024
kaxil
approved these changes
Dec 10, 2024
jedcunningham
approved these changes
Dec 10, 2024
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This is some cleanup/preporatory work in order to swap the Dag processor over to use the TaskSDK, and this small change is done to make the future work easier. The main bulk of this change is to remote the `get_*` helper methods and make `_file_stats` a defaultdict instead, and then also swap the DagFileStat class from a NamedTuple (which can't have defaults) to an attrs-defined class which does. To make some of the places of use nicer/still one line, the type of last_duration was changed form a timedelta to a float, as this was what the `get_last_runtime` method did, and we don't need any of the capabilities of a timedelta object elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is some cleanup/preporatory work in order to swap the Dag processor over
to use the TaskSDK, and this small change is done to make the future work
easier.
The main bulk of this change is to remote the
get_*helper methods and make_file_statsa defaultdict instead, and then also swap the DagFileStat classfrom a NamedTuple (which can't have defaults) to an attrs-defined class which
does.
To make some of the places of use nicer/still one line, the type of
last_duration was changed form a timedelta to a float, as this was what the
get_last_runtimemethod did, and we don't need any of the capabilities of atimedelta object elsewhere.