Better error handling to prevent flaky test_last_chance_exception_handling test#44909
Merged
ashb merged 1 commit intoapache:mainfrom Dec 13, 2024
Merged
Conversation
…dling test If the launched subprocess (which in tests just _immediately_ raises an Exception) exits very quickly before we even try to send the startup message it would fail with a BrokenPipeError. All we need to do in this case is handle it as the exit code of the task and it's message (which we already test) will cover it. This particular behaviour is hard to reliably catch in tests, so no tests are added here.
amoghrajesh
approved these changes
Dec 13, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Dec 13, 2024
…dling test (apache#44909) If the launched subprocess (which in tests just _immediately_ raises an Exception) exits very quickly before we even try to send the startup message it would fail with a BrokenPipeError. All we need to do in this case is handle it as the exit code of the task and it's message (which we already test) will cover it. This particular behaviour is hard to reliably catch in tests, so no tests are added here.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…dling test (apache#44909) If the launched subprocess (which in tests just _immediately_ raises an Exception) exits very quickly before we even try to send the startup message it would fail with a BrokenPipeError. All we need to do in this case is handle it as the exit code of the task and it's message (which we already test) will cover it. This particular behaviour is hard to reliably catch in tests, so no tests are added here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the launched subprocess (which in tests just immediately raises an
Exception) exits very quickly before we even try to send the startup message
it would fail with a BrokenPipeError. All we need to do in this case is handle
it as the exit code of the task and it's message (which we already test) will
cover it.
This particular behaviour is hard to reliably catch in tests, so no tests are
added here.