Implement Asset.ref for name or URI references#45028
Merged
uranusjr merged 5 commits intoapache:mainfrom Dec 26, 2024
Merged
Conversation
2 tasks
dab6e39 to
bb527de
Compare
bb527de to
5cd6c5d
Compare
5cd6c5d to
e6b3d71
Compare
1876468 to
15cffbc
Compare
6e82d46 to
f78ec93
Compare
Lee-W
reviewed
Dec 25, 2024
Lee-W
approved these changes
Dec 25, 2024
This allows us to refer to an asset without needing the original object, making it easier to schedule against an asset.
7db4a40 to
fa1adcf
Compare
2 tasks
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to refer to an asset without needing the original object, making it easier to schedule against an asset.
I also added some minor improvements to
register_asset_changeso we can save a db query or the asset-model conversion in some cases.There are a couple of possible sytax designs available:
I’m opting for the second one with a factory method since it is easier to implement, but we can discuss which one we like better.