Use Airflow config in SimpleAuthManager instead of Flask app config#45059
Merged
vincbeck merged 2 commits intoapache:mainfrom Dec 20, 2024
Merged
Use Airflow config in SimpleAuthManager instead of Flask app config#45059vincbeck merged 2 commits intoapache:mainfrom
SimpleAuthManager instead of Flask app config#45059vincbeck merged 2 commits intoapache:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- docs/apache-airflow/core-concepts/auth-manager/simple.rst: Language not supported
- airflow/config_templates/default_webserver_config.py: Evaluated as low risk
vincbeck
force-pushed
the
vincbeck/simple_am_config
branch
2 times, most recently
from
b0b9420 to
003418e
Compare
vincbeck
force-pushed
the
vincbeck/simple_am_config
branch
from
003418e to
e3a31a9
Compare
vincbeck
force-pushed
the
vincbeck/simple_am_config
branch
from
e3a31a9 to
f93bff1
Compare
jedcunningham
approved these changes
Dec 20, 2024
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simple auth manager uses the Flask config to get the list of users. Since we are moving away from Flask and simple auth manager should work without Flask, I propose to use the Airflow config instead. That also makes us one step closer to have the simple auth manager no longer dependent on Flask appbuilder.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.