Disable _sync_dag_perms until we can fix its implementation#45087
Merged
Disable _sync_dag_perms until we can fix its implementation#45087
Conversation
Currently _sync_dag_perms is FAB specific. We need to re-implement it using the auth manager interface. In the short term, we are going to disable it but this should be fixed and re-enabled before AF3 is released.
dimberman
requested review from
ephraimbuddy and
jedcunningham
as code owners
boring-cyborg
bot
added
the
area:Scheduler
jedcunningham
approved these changes
Dec 19, 2024
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Dec 19, 2024
…pache#45087)" This reverts commit 80c5f35.
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Dec 19, 2024
PR apache#45087 broke some tests and had a formatting error as well. This fixes it.
dimberman
pushed a commit
that referenced
this pull request
Dec 19, 2024
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…5087) * Disable _sync_dag_perms until we can fix its implementation Currently _sync_dag_perms is FAB specific. We need to re-implement it using the auth manager interface. In the short term, we are going to disable it but this should be fixed and re-enabled before AF3 is released. * comment sync_perm tests * comment sync_perm tests * Update tests/dag_processing/test_collection.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> * Update tests/dag_processing/test_collection.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…pache#45087)" (apache#45091) This reverts commit 80c5f35.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently _sync_dag_perms is FAB specific. We need to re-implement it using the auth manager interface. In the short term, we are going to disable it but this should be fixed and re-enabled before AF3 is released.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.