Prevent occasional 500 errors when installing npm dependencies#45143
Merged
potiuk merged 1 commit intoapache:mainfrom Dec 22, 2024
Merged
Prevent occasional 500 errors when installing npm dependencies#45143potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
potiuk
requested review from
amoghrajesh,
bbovenzi,
eladkal,
gopidesupavan,
jscheffl and
pierrejeambrun
potiuk
added
the
full tests needed
When we are installing npm dependencies, occasionally in CI we get 500 Internal Error. This change adds max 3 tries of such installations - retrying when 500 internal error is detected.
potiuk
force-pushed
the
protect-against-occasional-npm-500-errors
branch
from
2a57c31 to
a8205d7
Compare
amoghrajesh
reviewed
Dec 22, 2024
amoghrajesh
approved these changes
Dec 22, 2024
eladkal
approved these changes
Dec 22, 2024
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 22, 2024
Try num printed is now more human, and capture_output is added - it was missing in the original apache#45143
Member
|
Cool :) retries always helps.. |
potiuk
added a commit
that referenced
this pull request
Dec 22, 2024
Try num printed is now more human, and capture_output is added - it was missing in the original #45143
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…e#45143) When we are installing npm dependencies, occasionally in CI we get 500 Internal Error. This change adds max 3 tries of such installations - retrying when 500 internal error is detected.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Try num printed is now more human, and capture_output is added - it was missing in the original apache#45143
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we are installing npm dependencies, occasionally in CI we get 500 Internal Error. This change adds max 3 tries of such installations - retrying when 500 internal error is detected.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.