Sort "opts" element in click option dictionary before hashing#45156
Merged
potiuk merged 1 commit intoapache:mainfrom Dec 22, 2024
Merged
Sort "opts" element in click option dictionary before hashing#45156potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
potiuk
requested review from
amoghrajesh,
eladkal,
gopidesupavan and
jedcunningham
and removed request for
ashb and
jedcunningham
Some impleemntation details of click 8.1.8 caused instability in configuration directories that are produced by click config - the instability is in sequence of generated "opts" list - the sequence of options in it is random. While it can be likely fixed in later versions, better is to protect from it and sort the opts list before hashing the dict.
potiuk
force-pushed
the
sort-opts-in-click-commands
branch
from
521d569 to
abd5a64
Compare
gopidesupavan
approved these changes
Dec 22, 2024
Member
gopidesupavan
left a comment
gopidesupavan
left a comment
There was a problem hiding this comment.
cool :) finally cracked.. thank you for the fix..
hussein-awala
approved these changes
Dec 22, 2024
jscheffl
approved these changes
Dec 22, 2024
shubhamraj-git
approved these changes
Dec 22, 2024
Contributor
shubhamraj-git
left a comment
shubhamraj-git
left a comment
There was a problem hiding this comment.
Looks good! Must needed fix, thanks!
Member
Author
|
The failing test is intermittent |
Backport failed to create: v2-10-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 1796c40 v2-10-testThis should apply the commit to the v2-10-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 22, 2024
…shing (apache#45156) Some impleemntation details of click 8.1.8 caused instability in configuration directories that are produced by click config - the instability is in sequence of generated "opts" list - the sequence of options in it is random. While it can be likely fixed in later versions, better is to protect from it and sort the opts list before hashing the dict. (cherry picked from commit 1796c40) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 22, 2024
…shing (apache#45156) Some impleemntation details of click 8.1.8 caused instability in configuration directories that are produced by click config - the instability is in sequence of generated "opts" list - the sequence of options in it is random. While it can be likely fixed in later versions, better is to protect from it and sort the opts list before hashing the dict. (cherry picked from commit 1796c40) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Dec 22, 2024
…shing (#45156) (#45161) Some impleemntation details of click 8.1.8 caused instability in configuration directories that are produced by click config - the instability is in sequence of generated "opts" list - the sequence of options in it is random. While it can be likely fixed in later versions, better is to protect from it and sort the opts list before hashing the dict. (cherry picked from commit 1796c40)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 22, 2024
…#45156) Some impleemntation details of click 8.1.8 caused instability in configuration directories that are produced by click config - the instability is in sequence of generated "opts" list - the sequence of options in it is random. While it can be likely fixed in later versions, better is to protect from it and sort the opts list before hashing the dict. (cherry picked from commit 1796c40)
potiuk
added a commit
that referenced
this pull request
Dec 22, 2024
#45169) Some impleemntation details of click 8.1.8 caused instability in configuration directories that are produced by click config - the instability is in sequence of generated "opts" list - the sequence of options in it is random. While it can be likely fixed in later versions, better is to protect from it and sort the opts list before hashing the dict. (cherry picked from commit 1796c40)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 23, 2024
Click introduced breaking change for breeze opts behaviour fixed in apache#45156 however it did not force breeze image to upgrade click to newer version and it could have caused out-dated images to use older click version even if the image has been rebuilt. This PR also updates click version in the breeze image.
potiuk
added a commit
that referenced
this pull request
Dec 23, 2024
Click introduced breaking change for breeze opts behaviour fixed in #45156 however it did not force breeze image to upgrade click to newer version and it could have caused out-dated images to use older click version even if the image has been rebuilt. This PR also updates click version in the breeze image.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
…5177) Click introduced breaking change for breeze opts behaviour fixed in #45156 however it did not force breeze image to upgrade click to newer version and it could have caused out-dated images to use older click version even if the image has been rebuilt. This PR also updates click version in the breeze image. (cherry picked from commit a2b18d8) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Jan 11, 2025
…5177) Click introduced breaking change for breeze opts behaviour fixed in #45156 however it did not force breeze image to upgrade click to newer version and it could have caused out-dated images to use older click version even if the image has been rebuilt. This PR also updates click version in the breeze image. (cherry picked from commit a2b18d8) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…#45156) Some impleemntation details of click 8.1.8 caused instability in configuration directories that are produced by click config - the instability is in sequence of generated "opts" list - the sequence of options in it is random. While it can be likely fixed in later versions, better is to protect from it and sort the opts list before hashing the dict.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Click introduced breaking change for breeze opts behaviour fixed in apache#45156 however it did not force breeze image to upgrade click to newer version and it could have caused out-dated images to use older click version even if the image has been rebuilt. This PR also updates click version in the breeze image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some impleemntation details of click 8.1.8 caused instability in configuration directories that are produced by click config - the instability is in sequence of generated "opts" list - the sequence of options in it is random.
While it can be likely fixed in later versions, better is to protect from it and sort the opts list before hashing the dict.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.