Correctly import isabs from os.path#45178
Merged
potiuk merged 1 commit intoapache:mainfrom Dec 23, 2024
Merged
Conversation
The apache#45139 imported isabs from "airflow.www.app" - but isabs has been added there fairly recently and it is anyhow stdlib's os.path isabs - so it should be imported from there. This breaks fab 1.5.2 backport compatibility tests, so we need to cherry-pick it there alongside apache#45139
Member
Author
|
cc: @shubhamraj-git -> small thing I found out when backporting - isabs should be imported from os.path :) |
Member
Author
|
I am so glad we have compatibility tests :) |
Contributor
|
@potiuk Ohh yeah! Sorry for this. |
shubhamraj-git
approved these changes
Dec 23, 2024
Contributor
shubhamraj-git
left a comment
shubhamraj-git
left a comment
There was a problem hiding this comment.
+1, nice catch.
Thanks for the fix.
gopidesupavan
approved these changes
Dec 23, 2024
Member
Author
It were the tests that caught it - not me :) |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 23, 2024
The apache#45139 imported isabs from "airflow.www.app" - but isabs has been added there fairly recently and it is anyhow stdlib's os.path isabs - so it should be imported from there. This breaks fab 1.5.2 backport compatibility tests, so we need to cherry-pick it there alongside apache#45139 (cherry picked from commit 7002966)
potiuk
added a commit
that referenced
this pull request
Dec 23, 2024
The #45139 imported isabs from "airflow.www.app" - but isabs has been added there fairly recently and it is anyhow stdlib's os.path isabs - so it should be imported from there. This breaks fab 1.5.2 backport compatibility tests, so we need to cherry-pick it there alongside #45139 (cherry picked from commit 7002966)
potiuk
added a commit
that referenced
this pull request
Dec 24, 2024
The #45139 imported isabs from "airflow.www.app" - but isabs has been added there fairly recently and it is anyhow stdlib's os.path isabs - so it should be imported from there. This breaks fab 1.5.2 backport compatibility tests, so we need to cherry-pick it there alongside #45139 (cherry picked from commit 7002966)
4 tasks
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
The apache#45139 imported isabs from "airflow.www.app" - but isabs has been added there fairly recently and it is anyhow stdlib's os.path isabs - so it should be imported from there. This breaks fab 1.5.2 backport compatibility tests, so we need to cherry-pick it there alongside apache#45139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #45139 imported isabs from "airflow.www.app" - but isabs has been added there fairly recently and it is anyhow stdlib's os.path isabs - so it should be imported from there.
This breaks fab 1.5.2 backport compatibility tests, so we need to cherry-pick it there alongside #45139
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.