[AIRFLOW-3707] Group subpackages by cloud providers#4524
Conversation
|
@ashb Recently, you gave me a thumb up on a comment that pointed to this problem. |
67b27f6 to
846a5b8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4524 +/- ##
==========================================
- Coverage 74.35% 74.34% -0.01%
==========================================
Files 428 428
Lines 27947 27947
==========================================
- Hits 20779 20778 -1
- Misses 7168 7169 +1
Continue to review full report at Codecov.
|
ashb
left a comment
There was a problem hiding this comment.
This needs a note in updating, otherwise someone might try to install apache-airflow[s3] and be confused by it not working.
It might be nice to maintain the old names in the extra section for a release or two to ease upgrade too?
That's right. I will add it.
It is not necessary to enter a transitional period. Old installations will have already installed libraries. On new installations, the command will be made according to the documentation. It is also worth noting that the transition period is introduced in systems to ensure compatibility of computer systems, not as a time to learn for developer. I thought to enter a transition period, but by displaying an error message during installation, but I did not find a way. If there was a message for the developer, then a transitional period would make sense. Now we would only move the period where the programmer would be surprised. |
846a5b8 to
561a37d
Compare
|
@ashb I added note in |
2832d48 to
eebea6b
Compare
UPDATING.md
Outdated
There was a problem hiding this comment.
| the cloud provider. | |
| each cloud provider. |
This line break here also doesn't show up when rendered (check out https://github.com/apache/airflow/blob/eebea6bf2f8a70596697d3e976cf18bc97d5cbff/UPDATING.md for example) so this is a bit hard to read.
UPDATING.md
Outdated
eebea6b to
d9ea2d7
Compare
|
@ashb I have introduced your suggestions. Can you look again? |
d9ea2d7 to
dee34c8
Compare
|
@ashb Rebased and generated preview. http://toothsome-plant.surge.sh/installation.html Do I still have to do something to get the PRs merged? I received your acceptance, but the change was not merged. I do not understand what it means. I know you are overwhelmed with work. If I could improve your work in some way, I'm open to suggestion. |
dee34c8 to
8e7bcab
Compare
|
Review approval says "yes I'm happy with this change" -- the reason it hasn't merged yet is the tests aren't passing, and I hand't dug in to why (transient k8s failure again :( ) |
Make sure you have checked all steps below.
Jira
Description
I propose to group sub packages by. cloud providers. There is a good chance that if the user needs one package of the given clouds, he will need more in a moment. This will be more than consistent with the way the
gcp_apipackage works.Tests
Commits
Documentation
Code Quality
flake8