Skip to content

Comments

Skip building CI image when change does not touch python code#45281

Merged
potiuk merged 1 commit intoapache:mainfrom
potiuk:skip-image-building-in-simple-cases
Dec 30, 2024
Merged

Skip building CI image when change does not touch python code#45281
potiuk merged 1 commit intoapache:mainfrom
potiuk:skip-image-building-in-simple-cases

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Dec 30, 2024

In very simple changes we should skip building ci image altogether. This had been missing condition in one of the earlier refactors.

Follow-up after #45266


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

In very simple changes we should skip building ci image altogether.
This had been missing condition in one of the earlier refactors.

Follow-up after apache#45266
@potiuk
Copy link
Member Author

potiuk commented Dec 30, 2024

This will make things like https://github.com/apache/airflow/actions/runs/12544405502 build in seconds.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@potiuk potiuk merged commit 1e56eb2 into apache:main Dec 30, 2024
74 of 75 checks passed
@potiuk potiuk deleted the skip-image-building-in-simple-cases branch December 30, 2024 10:01
HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
…#45281)

In very simple changes we should skip building ci image altogether.
This had been missing condition in one of the earlier refactors.

Follow-up after apache#45266
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
…#45281)

In very simple changes we should skip building ci image altogether.
This had been missing condition in one of the earlier refactors.

Follow-up after apache#45266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants