AIP-72: Gracefully handle 'not-found' XCOMs in task sdk API client#45344
Merged
amoghrajesh merged 2 commits intoapache:mainfrom Jan 3, 2025
Merged
Conversation
amoghrajesh
commented
Jan 2, 2025
jscheffl
approved these changes
Jan 2, 2025
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
Looks good, just one comment. But not critical to move ahead.
8862d7d to
f8e4be0
Compare
jscheffl
approved these changes
Jan 2, 2025
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
Oh, much simpler now :-D
uranusjr
reviewed
Jan 2, 2025
Member
|
@amoghrajesh - can you please rebase that one -> we found and issue with @jscheffl with the new caching scheme - fixed in #45347 that would run "main" version of the tests. I am asking in all affected PRs to rebase. |
amoghrajesh
commented
Jan 2, 2025
Contributor
Author
Oh ok, let me rebase this one |
Contributor
Author
|
Hi @uranusjr are you ok with the reply on this comment? #45344 (comment) |
7c807b7 to
482fab5
Compare
uranusjr
approved these changes
Jan 3, 2025
1 task
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
…pache#45344) * AIP-72: Gracefully handle not-found XCOMs in task sdk API client * re raising exception for non 404
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…pache#45344) * AIP-72: Gracefully handle not-found XCOMs in task sdk API client * re raising exception for non 404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #45341
Testing results
DAG used:
Legacy
Task 1 XCom pushed:

Task 2 XCom consumed as None when absent:

Task SDK
Task 1 XCom pushed:

Task 2 XCom consumed as None when absent:

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.