Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
shahar1
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution!
Was the deprecation discussed anywhere on GitHub / sphinx dev list / anywhere else publicly?
If so, I'd be happy if you could share a link, so we'd be in the loop for the next times :)
The PR to move This is preparatory work for a future v3 of the objects.inv file format. A |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
(cherry picked from commit 57be063) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
(cherry picked from commit 57be063) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Hello,
In Sphinx we are looking to refactor handling of inventory reading, which might involve deprecating or removing
InventoryFileReader. Airflow is one of four projects I have found in the wild that uses it, but your usage can be replaced with a single call to.readline().decode(), as you are only sanity-checking the first line of content.A