Skip to content

Comments

Don't display table/card header and pagination when no rows are present.#45501

Merged
pierrejeambrun merged 2 commits intoapache:mainfrom
tirkarthi:fix-no-rows-message
Jan 10, 2025
Merged

Don't display table/card header and pagination when no rows are present.#45501
pierrejeambrun merged 2 commits intoapache:mainfrom
tirkarthi:fix-no-rows-message

Conversation

@tirkarthi
Copy link
Contributor

If there are no rows to display the current table component displays the header and pagination with no rows message in between. The header and pagination can be hidden when there are no rows.

main

image

After PR

image

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 9, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits, but looking good.

@tirkarthi tirkarthi force-pushed the fix-no-rows-message branch from f8708eb to 7a02c64 Compare January 9, 2025 17:02
@pierrejeambrun pierrejeambrun merged commit db739d9 into apache:main Jan 10, 2025
35 checks passed
karenbraganz pushed a commit to karenbraganz/airflow that referenced this pull request Jan 13, 2025
…nt. (apache#45501)

* Don't display table/card and pagination when no rows are present.

* Refactor hasRows check to front.
HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
…nt. (apache#45501)

* Don't display table/card and pagination when no rows are present.

* Refactor hasRows check to front.
dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
…nt. (apache#45501)

* Don't display table/card and pagination when no rows are present.

* Refactor hasRows check to front.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
…nt. (apache#45501)

* Don't display table/card and pagination when no rows are present.

* Refactor hasRows check to front.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants