AIP-84 Add ordering to task instances and mapped task instances list#45802
Merged
pierrejeambrun merged 9 commits intoapache:mainfrom Jan 23, 2025
Merged
AIP-84 Add ordering to task instances and mapped task instances list#45802pierrejeambrun merged 9 commits intoapache:mainfrom
pierrejeambrun merged 9 commits intoapache:mainfrom
Conversation
prabhusneha
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
1 task
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice.
I think the original comment was also referring to data_interval_start/end were you able to take a look ?
Also some test would be great. Not all sort params are tested for task instances, but that wouldn't hurt.
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
…pache#45802) * add attributes to task instance ordering * add attributes to task instance ordering * add additional ordering attributes and add test * add test for mapped task instances, parametrized the tests --------- Co-authored-by: Sneha Prabhu <snehaprabhu@Snehas-MacBook-Pro.local>
gpathak128
pushed a commit
to gpathak128/airflow
that referenced
this pull request
Jan 29, 2025
…pache#45802) * add attributes to task instance ordering * add attributes to task instance ordering * add additional ordering attributes and add test * add test for mapped task instances, parametrized the tests --------- Co-authored-by: Sneha Prabhu <snehaprabhu@Snehas-MacBook-Pro.local>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…pache#45802) * add attributes to task instance ordering * add attributes to task instance ordering * add additional ordering attributes and add test * add test for mapped task instances, parametrized the tests --------- Co-authored-by: Sneha Prabhu <snehaprabhu@Snehas-MacBook-Pro.local>
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…pache#45802) * add attributes to task instance ordering * add attributes to task instance ordering * add additional ordering attributes and add test * add test for mapped task instances, parametrized the tests --------- Co-authored-by: Sneha Prabhu <snehaprabhu@Snehas-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #43778
Added additional ordering options to list task instance and mapped task instances.