Skip to content

Comments

Kubernetes Callbacks - Include pod instance as paramter for progress_callback#46126

Closed
tiberio-baptista wants to merge 1 commit intoapache:mainfrom
tiberio-baptista:imp/progress-callback-pod
Closed

Kubernetes Callbacks - Include pod instance as paramter for progress_callback#46126
tiberio-baptista wants to merge 1 commit intoapache:mainfrom
tiberio-baptista:imp/progress-callback-pod

Conversation

@tiberio-baptista
Copy link

This PR modifies the Kubernetes callback class in order to include the pod instance in the progress_callback method. PodManager has been modified to always include the observed pod for this method call.

This enables getting access to the pod's details (name, annotations, labels, …) during runtime, helping with use cases such as enriching/modifying received log lines and conditional script/application execution.

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 27, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you going to maintain compatibility with existing callbacks written by people ?

@tiberio-baptista
Copy link
Author

How are you going to maintain compatibility with existing callbacks written by people ?

That's a good question that I hadn't considered.

For compatibility's sake, we could remove pod from the callback method parameters, and PodManager will instead provide pod as part of kwargs, becoming an optional parameter.

I'll modify PR once I get back to my PC.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 14, 2025
@github-actions github-actions bot closed this Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants