Kubernetes Callbacks - Include pod instance as paramter for progress_callback#46126
Kubernetes Callbacks - Include pod instance as paramter for progress_callback#46126tiberio-baptista wants to merge 1 commit intoapache:mainfrom
progress_callback#46126Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
potiuk
left a comment
There was a problem hiding this comment.
How are you going to maintain compatibility with existing callbacks written by people ?
That's a good question that I hadn't considered. For compatibility's sake, we could remove I'll modify PR once I get back to my PC. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
This PR modifies the Kubernetes callback class in order to include the pod instance in the
progress_callbackmethod.PodManagerhas been modified to always include the observed pod for this method call.This enables getting access to the pod's details (name, annotations, labels, …) during runtime, helping with use cases such as enriching/modifying received log lines and conditional script/application execution.