Skip to content

Minor cleanup and better docstrings/comments for DAG parsing#46164

Merged
jedcunningham merged 8 commits intoapache:mainfrom
astronomer:better_comments_docstrings
Feb 3, 2025
Merged

Minor cleanup and better docstrings/comments for DAG parsing#46164
jedcunningham merged 8 commits intoapache:mainfrom
astronomer:better_comments_docstrings

Conversation

@jedcunningham
Copy link
Copy Markdown
Member

There is no real functional changes in this PR - just comments, doc strings, moving an import, and some logging cleanup.

Copy link
Copy Markdown
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
One comment

Comment thread airflow/dag_processing/bundles/manager.py
Comment thread airflow/dag_processing/manager.py Outdated
Comment thread airflow/dag_processing/manager.py Outdated
Comment thread airflow/dag_processing/manager.py Outdated
Comment thread airflow/dag_processing/bundles/base.py Outdated
Comment thread airflow/dag_processing/bundles/base.py Outdated
Comment thread airflow/dag_processing/bundles/base.py Outdated
Comment thread airflow/dag_processing/bundles/base.py Outdated
Copy link
Copy Markdown
Contributor

@dstandish dstandish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions

Comment thread airflow/dag_processing/bundles/base.py Outdated
Comment thread airflow/dag_processing/bundles/base.py Outdated
Comment thread airflow/dag_processing/bundles/base.py Outdated
@jedcunningham jedcunningham added the full tests needed We need to run full set of tests for this PR to merge label Jan 31, 2025
@jedcunningham jedcunningham reopened this Jan 31, 2025
@jedcunningham jedcunningham force-pushed the better_comments_docstrings branch from 2074641 to 1de0c04 Compare January 31, 2025 14:15
@jedcunningham jedcunningham force-pushed the better_comments_docstrings branch from 1de0c04 to bd8e7e2 Compare February 3, 2025 18:28
@jedcunningham jedcunningham merged commit 20d7c60 into apache:main Feb 3, 2025
@jedcunningham jedcunningham deleted the better_comments_docstrings branch February 3, 2025 19:44
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
…46164)

There is no real functional changes in this PR - just comments, doc strings,
moving an import, and some logging cleanup.

Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
…46164)

There is no real functional changes in this PR - just comments, doc strings,
moving an import, and some logging cleanup.

Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIP-66: DAG Bundle/Manifest area:DAG-processing full tests needed We need to run full set of tests for this PR to merge

Projects

Development

Successfully merging this pull request may close these issues.

3 participants