Remove log asserts from HDFS tests#46263
Merged
potiuk merged 1 commit intoapache:mainfrom Jan 30, 2025
Merged
Conversation
Member
|
VERY VERY VERY MUCH AGREE |
potiuk
approved these changes
Jan 30, 2025
Member
|
Thanks @jscheffl for the bold approach ! |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 30, 2025
Similarly to apache#46263 - there is no real value in keeping tests for logs in Livy - and caplog tests are known to be super vulnerable to side-effects from other tests. Since those tests add no value, we should just remove them without replacement.
jedcunningham
pushed a commit
that referenced
this pull request
Jan 30, 2025
Similarly to #46263 - there is no real value in keeping tests for logs in Livy - and caplog tests are known to be super vulnerable to side-effects from other tests. Since those tests add no value, we should just remove them without replacement.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Similarly to apache#46263 - there is no real value in keeping tests for logs in Livy - and caplog tests are known to be super vulnerable to side-effects from other tests. Since those tests add no value, we should just remove them without replacement.
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Jan 30, 2025
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Jan 30, 2025
Similarly to apache#46263 - there is no real value in keeping tests for logs in Livy - and caplog tests are known to be super vulnerable to side-effects from other tests. Since those tests add no value, we should just remove them without replacement.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Jan 30, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Jan 30, 2025
Similarly to apache#46263 - there is no real value in keeping tests for logs in Livy - and caplog tests are known to be super vulnerable to side-effects from other tests. Since those tests add no value, we should just remove them without replacement.
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
Similarly to apache#46263 - there is no real value in keeping tests for logs in Livy - and caplog tests are known to be super vulnerable to side-effects from other tests. Since those tests add no value, we should just remove them without replacement.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
Similarly to apache#46263 - there is no real value in keeping tests for logs in Livy - and caplog tests are known to be super vulnerable to side-effects from other tests. Since those tests add no value, we should just remove them without replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not a fan of ... actually I dislike caplog to implement tests expecting logs. On one side it does not tell anything about the tested function, it needs to know internals of logging and... as today it often causes problems if log settigns side effects jjust break the test.
For the HDFS test, the check for caplog does not bring any benefit in my view, therefore removing caplog w/o replacement. This repairs parts of broken main in https://github.com/apache/airflow/actions/runs/13038931877/job/36376761299