Skip to content

Comments

Validate body to be defined when the server/network is not available.#46275

Merged
jscheffl merged 1 commit intoapache:mainfrom
tirkarthi:fix-error-alert
Jan 30, 2025
Merged

Validate body to be defined when the server/network is not available.#46275
jscheffl merged 1 commit intoapache:mainfrom
tirkarthi:fix-error-alert

Conversation

@tirkarthi
Copy link
Contributor

I noticed few times during development when the fastapi server is restarting or down with UI open where error.body is not defined resulting in below stacktrace and UI crashing.

To reproduce :

  1. Run fastapi in dev mode
  2. Open home page
  3. Stop fastapi server and navigate to another page in UI.

Before

image

After PR

image

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 30, 2025
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@jscheffl jscheffl merged commit 3d40f8f into apache:main Jan 30, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants