Nuking extra code branching in task runner for inlets, outlets#46302
Merged
amoghrajesh merged 3 commits intoapache:mainfrom Jan 31, 2025
Merged
Nuking extra code branching in task runner for inlets, outlets#46302amoghrajesh merged 3 commits intoapache:mainfrom
amoghrajesh merged 3 commits intoapache:mainfrom
Conversation
ashb
approved these changes
Jan 31, 2025
| outlet_events=outlet_events, | ||
| ) | ||
| ok_response = SUPERVISOR_COMMS.get_message() # type: ignore | ||
| if isinstance(ok_response, OKResponse) and not ok_response.ok: |
Member
There was a problem hiding this comment.
Suggested change
| if isinstance(ok_response, OKResponse) and not ok_response.ok: | |
| if not isinstance(ok_response, OKResponse) or not ok_response.ok: |
Just in case we get some other object type back?
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
Prab-27
pushed a commit
to Prab-27/airflow
that referenced
this pull request
Jan 31, 2025
…e#46302) Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…e#46302) Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…e#46302) Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic to check for task inlets, outlets in task runner had unwanted code branching - if, else when it could have been simpler. (Yea, i wrote the initial code, but didnt realise that time :)).
This PR simplifies that part by keeping only the
ifand adding a finally. Additionally, renamedmsgthat receivedOKResponseasok_responseto not confuse with the actual message from supervsior.Extended the tests for OK = true as well as false.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.