Skip to content

Make var naming a little more consistent in dag processor#46341

Merged
jedcunningham merged 1 commit intoapache:mainfrom
astronomer:dag-processor-renames-cleanups
Feb 1, 2025
Merged

Make var naming a little more consistent in dag processor#46341
jedcunningham merged 1 commit intoapache:mainfrom
astronomer:dag-processor-renames-cleanups

Conversation

@dstandish
Copy link
Contributor

Previously we dealt with filepaths, just string paths. Now we deal with a different object, DagFileInfo which is basically bundle name and rel path. Updating the names of some of these functions and variables makes it a little more intuitive to deal with.

@dstandish dstandish added the full tests needed We need to run full set of tests for this PR to merge label Jan 31, 2025
Previously we dealt with filepaths, just string paths.  Now we deal with a different object, DagFileInfo which is basically bundle name and rel path.  Updating the names of some of these functions and variables makes it a little more intuitive to deal with.
@dstandish dstandish force-pushed the dag-processor-renames-cleanups branch from ee066a4 to 09e3e97 Compare February 1, 2025 00:02
@jedcunningham jedcunningham merged commit 3b27a4b into apache:main Feb 1, 2025
91 checks passed
@jedcunningham jedcunningham deleted the dag-processor-renames-cleanups branch February 1, 2025 11:08
amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Feb 3, 2025
Previously we dealt with filepaths, just string paths.  Now we deal with a different object, DagFileInfo which is basically bundle name and rel path.  Updating the names of some of these functions and variables makes it a little more intuitive to deal with.
dabla pushed a commit to dabla/airflow that referenced this pull request Feb 3, 2025
Previously we dealt with filepaths, just string paths.  Now we deal with a different object, DagFileInfo which is basically bundle name and rel path.  Updating the names of some of these functions and variables makes it a little more intuitive to deal with.
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
Previously we dealt with filepaths, just string paths.  Now we deal with a different object, DagFileInfo which is basically bundle name and rel path.  Updating the names of some of these functions and variables makes it a little more intuitive to deal with.
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
Previously we dealt with filepaths, just string paths.  Now we deal with a different object, DagFileInfo which is basically bundle name and rel path.  Updating the names of some of these functions and variables makes it a little more intuitive to deal with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIP-66: DAG Bundle/Manifest area:DAG-processing full tests needed We need to run full set of tests for this PR to merge

Projects

Development

Successfully merging this pull request may close these issues.

2 participants