Skip to content

Skip ci if pr is a draft commit#46353

Closed
aritra24 wants to merge 1 commit into
apache:mainfrom
aritra24:skip_draft
Closed

Skip ci if pr is a draft commit#46353
aritra24 wants to merge 1 commit into
apache:mainfrom
aritra24:skip_draft

Conversation

@aritra24
Copy link
Copy Markdown
Collaborator

@aritra24 aritra24 commented Feb 2, 2025

There's no need to run ci for wip
commits.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

There's no need to run ci for wip
commits.
@aritra24
Copy link
Copy Markdown
Collaborator Author

aritra24 commented Feb 2, 2025

Draft prs shouldn't go through all the build/test?

@jscheffl
Copy link
Copy Markdown
Contributor

jscheffl commented Feb 2, 2025

I think it is valueable to run Draft PRs also through CI. Then as a contributor you can have early feedback. Before opening a PR up toreviewers and generating notifications. What else should a WIP/Draft PR be for?
Or do we need to fear that we have too high CI workload and need to reduce infra capacity? Then still a reduced run would be of value in my view.

@aritra24
Copy link
Copy Markdown
Collaborator Author

aritra24 commented Feb 2, 2025

I think that's fair, I was coming in from a perspective of I know my pr is half baked and is not ready to be merged (and so is highly likely to fail in ci). I mainly use drafts to get early feedback on direction of code from specific folks with context on the task.

But I don't have a strong opinion on this so I'm good with closing it as not needed.

@jedcunningham
Copy link
Copy Markdown
Member

I agree with Jens that there is value in having them go through CI. If it's half baked and a bunch of tests are failing, you won't catch any flak at all. In fact, it's nice you can defer notifying reviewers until you know everything is green, particularly if you think tests across a lot of places may fail. I do it pretty often myself.

We already use selective checks to optimize and only run tests that need to run for a given change. I'm sure there is still gains to be had, but the low hanging fruit is already picked there (at least afaik 😄).

Thanks for the PR, but I'm going to close this one.

@aritra24 aritra24 deleted the skip_draft branch February 3, 2025 05:04
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Feb 4, 2025

You can always add [skip ci] in your PR title or message if you want to skip CI in draft PR https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants