Fix attribute error on accessing Gitbundle.repo_url#46394
Merged
jedcunningham merged 2 commits intoapache:mainfrom Feb 4, 2025
Merged
Fix attribute error on accessing Gitbundle.repo_url#46394jedcunningham merged 2 commits intoapache:mainfrom
jedcunningham merged 2 commits intoapache:mainfrom
Conversation
The position where we added the repo_url makes it unavailable on the GitBundle instance when the connection id is not defined. This PR fixes it and added a test to check that it has the attribute when the connection ID is not defined
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
ephraimbuddy
force-pushed
the
fix-repo-url-attr-error
branch
from
b0e1976 to
1c2cbae
Compare
jedcunningham
approved these changes
Feb 3, 2025
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
The position where we added the repo_url makes it unavailable on the GitBundle instance when the connection id is not defined. This PR fixes it and added a test to check that it has the attribute when the connection ID is not defined Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
The position where we added the repo_url makes it unavailable on the GitBundle instance when the connection id is not defined. This PR fixes it and added a test to check that it has the attribute when the connection ID is not defined Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The position where we added the repo_url makes it unavailable on the GitBundle instance when the connection id is not defined. This PR fixes it and added a test to check that it has the attribute when the connection ID is not defined