Add lock to BaseDagBundle and use it in GitDagBundle#46501
Merged
ephraimbuddy merged 2 commits intoapache:mainfrom Feb 6, 2025
Merged
Add lock to BaseDagBundle and use it in GitDagBundle#46501ephraimbuddy merged 2 commits intoapache:mainfrom
lock to BaseDagBundle and use it in GitDagBundle#46501ephraimbuddy merged 2 commits intoapache:mainfrom
Conversation
`initialize` and `refresh` need to be safe to call from different threads/processes, so this adds a simple `lock` context manager that bundles can use if the underlying implementation doesn't allow for that. For example, `GitDagBundle` is the first taker.
jedcunningham
added
full tests needed
dstandish
reviewed
Feb 6, 2025
dstandish
reviewed
Feb 6, 2025
dstandish
reviewed
Feb 6, 2025
dstandish
reviewed
Feb 6, 2025
jedcunningham
force-pushed
the
bundle_locking
branch
from
91ba728 to
87b42a4
Compare
ephraimbuddy
approved these changes
Feb 6, 2025
insomnes
pushed a commit
to insomnes/airflow
that referenced
this pull request
Feb 6, 2025
) * Add `lock` to `BaseDagBundle` and use it in `GitDagBundle` `initialize` and `refresh` need to be safe to call from different threads/processes, so this adds a simple `lock` context manager that bundles can use if the underlying implementation doesn't allow for that. For example, `GitDagBundle` is the first taker. * review feedback
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
) * Add `lock` to `BaseDagBundle` and use it in `GitDagBundle` `initialize` and `refresh` need to be safe to call from different threads/processes, so this adds a simple `lock` context manager that bundles can use if the underlying implementation doesn't allow for that. For example, `GitDagBundle` is the first taker. * review feedback
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
) * Add `lock` to `BaseDagBundle` and use it in `GitDagBundle` `initialize` and `refresh` need to be safe to call from different threads/processes, so this adds a simple `lock` context manager that bundles can use if the underlying implementation doesn't allow for that. For example, `GitDagBundle` is the first taker. * review feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initializeandrefreshneed to be safe to call from different threads/processes, so this adds a simplelockcontext manager that bundles can use if the underlying implementation doesn't allow for that.For example,
GitDagBundleis the first taker.closes: #46444