AIP-84 Adding logging actions#46814
Merged
pierrejeambrun merged 11 commits intoapache:mainfrom Feb 24, 2025
Merged
Conversation
vatsrahul1001
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
I see that the PR is in Draft, from a first quick read it looks good.
Is there anything else you would like to add to the PR before I do an in depth review ?
Contributor
Author
We are good. I will raise another PR for rest of endpoint |
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looks good overall. Just a few suggestions
…flow into AIP84-add-logging-actions
pierrejeambrun
changed the title
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice a couple of small suggestions should be ready to merge after that.
pierrejeambrun
approved these changes
Feb 24, 2025
Member
|
Nice thanks. |
potiuk
pushed a commit
that referenced
this pull request
Feb 26, 2025
* add logging actions * fix failing test * implement review comments * implement review comments
potiuk
pushed a commit
that referenced
this pull request
Feb 26, 2025
* add logging actions * fix failing test * implement review comments * implement review comments
potiuk
pushed a commit
that referenced
this pull request
Feb 26, 2025
* add logging actions * fix failing test * implement review comments * implement review comments
potiuk
pushed a commit
that referenced
this pull request
Feb 26, 2025
* add logging actions * fix failing test * implement review comments * implement review comments
potiuk
pushed a commit
that referenced
this pull request
Feb 26, 2025
* add logging actions * fix failing test * implement review comments * implement review comments
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* add logging actions * fix failing test * implement review comments * implement review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #44057
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.